Re: [PATCH 1/2] config.mak.dev: workaround gcc 12 bug affecting "pedantic" CI job

From: Carlo Arenas <carenas@gmail.com>
Date: Apr 16, 2022, 00:08 UTC
Message-ID: <CAPUEspgYU_797VSsdLWVqLXjSYsKfJhUb7M=jdouF01kHcKQyA@mail.gmail.com>
In-Reply-To: <220416.8635idc3mk.gmgdl@evledraar.gmail.com>

On Fri, Apr 15, 2022 at 4:45 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 16 quoted lines

> On Fri, Apr 15 2022, Carlo Marcelo Arenas Belón wrote:
> > diff --git a/config.mak.dev b/config.mak.dev
> > index 3deb076d5e3..335efd46203 100644
> > --- a/config.mak.dev
> > +++ b/config.mak.dev
> > @@ -65,4 +65,9 @@ DEVELOPER_CFLAGS += -Wno-uninitialized
> >  endif
> >  endif
> >
> > +# https://bugzilla.redhat.com/show_bug.cgi?id=2075786
> > +ifneq ($(filter gcc12,$(COMPILER_FEATURES)),)
> > +DEVELOPER_CFLAGS += -Wno-error=stringop-overread
> > +endif
>
> What I meant with "just set -Wno-error=stringop-overread on gcc12 for
> dir.(o|s|sp)?" was that you can set this per-file:

of course, but that change goes in the Makefile and therefore affects ALL builds, this one only affects DEVELOPER=1 and is therefore more narrow.

that is what I meant with "has been punted" in my commit message.

>         dir.sp dir.s dir.o: EXTRA_CPPFLAGS += -Wno-error=stringop-overread

I know at least one developer that will then rightfully complain that the git build doesn't work in AIX with xl after this.

Carlo