Re: [PATCH 2/2] config.mak.dev: alternative workaround to gcc 12 warning in http.c

From: Carlo Arenas <carenas@gmail.com>
Date: Apr 16, 2022, 00:51 UTC
Message-ID: <CAPUEsphXnLfnoM6qznVhaxVdOPk-38+Jaj7OEOY7bEvMiDgz3g@mail.gmail.com>
In-Reply-To: <xmqqwnfp98ix.fsf@gitster.g>

On Fri, Apr 15, 2022 at 5:28 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

>
> Carlo Arenas <carenas@gmail.com> writes:
>
> > this would be IMHO a better fix than the one currently queued in
> > ab/http-gcc-12-workaround and indeed squashes the warning with the gcc
> > 12 version that is likely to be released with Fedora 36,
>
> That is an excellent news, as ...

Sadly I botched the test, and was doubly confused because Ævar might have botched it too the same way as he originally reported it worked[1] for him, only to say the opposite in the commit message for the reroll.

the warning is not squashed even if we do the more aggressive BUG if not NULL first and now I am even doubting there was a real bug to begin with.

Neither this one or the previous one had bugs reported to gcc AFAIK, until I raised[2] the previous one with Fedora, so there is no confirmation either from their side that they are indeed bugs yet.

Carlo

[1] https://lore.kernel.org/git/220127.86mtjhdeme.gmgdl@evledraar.gmail.com/ [2] https://bugzilla.redhat.com/show_bug.cgi?id=2075786