Re: [PATCH v1 3/3] difftool: add space after full stop in comments

From: Carlo Arenas <carenas@gmail.com>
Date: Oct 2, 2021, 20:12 UTC
Message-ID: <CAPUEspgC80_jMJ6Vy8G7YW0v9NXusGCSLzpeBgVZFXpPKJ7a7w@mail.gmail.com>
In-Reply-To: <CABPp-BGq27kdugX5JivX7uFLmCmHXCsRjqfaA1Q2PXHZ4hCznw@mail.gmail.com>

On Sat, Oct 2, 2021 at 12:38 PM Elijah Newren <newren@gmail.com> wrote:

Show 10 quoted lines

>
> On Sat, Oct 2, 2021 at 11:49 AM Andrei Rybak <rybak.a.v@gmail.com> wrote:
> >
> > These punctuation typos were found using:
> >
> >     git grep -P ' [a-z0-9A-Z-]+[.][A-Z][A-Za-z-]+ '
>
> While Junio has commented that two spaces after the full stop in
> fixed-width source code viewing looks better, and I personally prefer
> that style as well, I don't think these are worth "fixing".

FWIW those are not adding a second space, but adding ANY space between a "." and beginning of the next sentence.

> you separated this from the other changes, but I'd rather see this
> patch dropped.

While I don't think encouraging this kind of "fixes" might make sense, the work was already done and the "churn" is very small (only 2 places out of ~2K), where we have in the codebase: ".<space><space>"

Carlo