Re: [PATCH v1 3/3] difftool: add space after full stop in comments

From: Elijah Newren <newren@gmail.com>
Date: Oct 2, 2021, 19:36 UTC
Message-ID: <CABPp-BGq27kdugX5JivX7uFLmCmHXCsRjqfaA1Q2PXHZ4hCznw@mail.gmail.com>
In-Reply-To: <20211002184407.117282-4-rybak.a.v@gmail.com>

On Sat, Oct 2, 2021 at 11:49 AM Andrei Rybak <rybak.a.v@gmail.com> wrote:

>
> These punctuation typos were found using:
>
>     git grep -P ' [a-z0-9A-Z-]+[.][A-Z][A-Za-z-]+ '

While Junio has commented that two spaces after the full stop in fixed-width source code viewing looks better, and I personally prefer that style as well, I don't think these are worth "fixing". I'm glad you separated this from the other changes, but I'd rather see this patch dropped.

Show 34 quoted lines

>
> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
>
> I've also looked for similar typos around commas and semicolons and didn't find
> any.
>
>  builtin/difftool.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/difftool.c b/builtin/difftool.c
> index bb9fe7245a..d9a4e55caf 100644
> --- a/builtin/difftool.c
> +++ b/builtin/difftool.c
> @@ -529,7 +529,7 @@ static int run_dir_diff(const char *extcmd, int symlinks, const char *prefix,
>                 goto finish;
>
>         /*
> -        * Changes to submodules require special treatment.This loop writes a
> +        * Changes to submodules require special treatment. This loop writes a
>          * temporary file to both the left and right directories to show the
>          * change in the recorded SHA1 for the submodule.
>          */
> @@ -548,7 +548,7 @@ static int run_dir_diff(const char *extcmd, int symlinks, const char *prefix,
>         }
>
>         /*
> -        * Symbolic links require special treatment.The standard "git diff"
> +        * Symbolic links require special treatment. The standard "git diff"
>          * shows only the link itself, not the contents of the link target.
>          * This loop replicates that behavior.
>          */
> --
> 2.33.0