git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1 3/3] difftool: add space after full stop in comments

From
David Aguilar <davvid@gmail.com>
Date
Oct 11, 2021, 15:42 UTC
Message-ID
<CAJDDKr7KUP3BPBU+C6=Yn+=fTebQNMDMLsQqFRTe_CRfRyJA0w@mail.gmail.com>
In-Reply-To
<20211002184407.117282-4-rybak.a.v@gmail.com>
On Sat, Oct 2, 2021 at 11:49 AM Andrei Rybak <rybak.a.v@gmail.com> wrote:
Show 36 quoted lines
>
> These punctuation typos were found using:
>
>     git grep -P ' [a-z0-9A-Z-]+[.][A-Z][A-Za-z-]+ '
>
> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
>
> I've also looked for similar typos around commas and semicolons and didn't find
> any.
>
>  builtin/difftool.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/builtin/difftool.c b/builtin/difftool.c
> index bb9fe7245a..d9a4e55caf 100644
> --- a/builtin/difftool.c
> +++ b/builtin/difftool.c
> @@ -529,7 +529,7 @@ static int run_dir_diff(const char *extcmd, int symlinks, const char *prefix,
>                 goto finish;
>
>         /*
> -        * Changes to submodules require special treatment.This loop writes a
> +        * Changes to submodules require special treatment. This loop writes a
>          * temporary file to both the left and right directories to show the
>          * change in the recorded SHA1 for the submodule.
>          */
> @@ -548,7 +548,7 @@ static int run_dir_diff(const char *extcmd, int symlinks, const char *prefix,
>         }
>
>         /*
> -        * Symbolic links require special treatment.The standard "git diff"
> +        * Symbolic links require special treatment. The standard "git diff"
>          * shows only the link itself, not the contents of the link target.
>          * This loop replicates that behavior.
>          */
Heads-up -- this 2nd hunk is already in "next". Please see:

28c10ecbfc (difftool: add a missing space to the run_dir_diff() comments, 2021-09-30)

The 1st hunk above it (submodules) is still relevant.

It might be worth rebasing this patch against the da/difftool topic in "next". This patch should become a one-liner once that's done.

-- 
David
Previous: Elijah Newren
Message 11 of 11 in “Typofixes”
  1. 0/3 TypofixesAndrei Rybak, Oct 2, 2021
  2. 1/3 *: spell Latin abbreviations correctlyAndrei Rybak, Oct 2, 2021
  3. Elijah NewrenOct 2, 2021
  4. Ævar Arnfjörð BjarmasonOct 2, 2021
  5. 2/3 *: fix spelling typosAndrei Rybak, Oct 2, 2021
  6. Elijah NewrenOct 2, 2021
  7. 3/3 difftool: add space after full stop in commentsAndrei Rybak, Oct 2, 2021
  8. Elijah NewrenOct 2, 2021
  9. Carlo ArenasOct 2, 2021
  10. Elijah NewrenOct 2, 2021
  11. David AguilarOct 11, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.