Re: [PATCH v1 3/3] difftool: add space after full stop in comments

From: Elijah Newren <newren@gmail.com>
Date: Oct 2, 2021, 23:41 UTC
Message-ID: <CABPp-BHTHcK7T32zbcusT8vcv=j2-o_+8SEzkAJczU85r_LcEQ@mail.gmail.com>
In-Reply-To: <CAPUEspgC80_jMJ6Vy8G7YW0v9NXusGCSLzpeBgVZFXpPKJ7a7w@mail.gmail.com>

On Sat, Oct 2, 2021 at 1:12 PM Carlo Arenas <carenas@gmail.com> wrote:

Show 15 quoted lines

>
> On Sat, Oct 2, 2021 at 12:38 PM Elijah Newren <newren@gmail.com> wrote:
> >
> > On Sat, Oct 2, 2021 at 11:49 AM Andrei Rybak <rybak.a.v@gmail.com> wrote:
> > >
> > > These punctuation typos were found using:
> > >
> > >     git grep -P ' [a-z0-9A-Z-]+[.][A-Z][A-Za-z-]+ '
> >
> > While Junio has commented that two spaces after the full stop in
> > fixed-width source code viewing looks better, and I personally prefer
> > that style as well, I don't think these are worth "fixing".
>
> FWIW those are not adding a second space, but adding ANY space between
> a "." and beginning of the next sentence.

Oh! I didn't look closely enough (I'll blame gmail's variable-width font). Thanks for correcting me. Yes, if there's no space at all between the full stop and the next character, then that makes it more annoying. So, ignore what I said earlier, I think this patch is good.