git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 10/10] gc: do not repack promisor packfiles

From
Christian Couder <christian.couder@gmail.com>
Date
Dec 2, 2017, 17:39 UTC
Message-ID
<CAP8UFD10YsCQtiFtLtzQ-PKsY93QaDC4zsO+k1tfauBs8ntt1w@mail.gmail.com>
In-Reply-To
<20171121210720.21376-11-git@jeffhostetler.com>
On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler <git@jeffhostetler.com> wrote:
> From: Jonathan Tan <jonathantanmy@google.com>
Show 5 quoted lines
>  pack_as_from_promisor () {
>         HASH=$(git -C repo pack-objects .git/objects/pack/pack) &&
>         >repo/.git/objects/pack/pack-$HASH.promisor
> +       echo $HASH
>  }

Now the exit code of the above function will always be the exit code of "echo $HASH". It seems to me that it would be better to add "&&" at the end of the line above the "echo $HASH".

Previous: Jeff HostetlerNext: Jeff Hostetler
Message 6 of 20 in “Partial clone part 2: fsck and promisors”
  1. 00/10 Partial clone part 2: fsck and promisorsJeff Hostetler, Nov 21, 2017
  2. 01/10 extension.partialclone: introduce partial clone extensionJeff Hostetler, Nov 21, 2017
  3. 04/10 fsck: support referenced promisor objectsJeff Hostetler, Nov 21, 2017
  4. 09/10 rev-list: support termination at promisor objectsJeff Hostetler, Nov 21, 2017
  5. 10/10 gc: do not repack promisor packfilesJeff Hostetler, Nov 21, 2017
  6. Christian CouderDec 2, 2017
  7. Jeff HostetlerDec 5, 2017
  8. 05/10 fsck: support promisor objects as CLI argumentJeff Hostetler, Nov 21, 2017
  9. 08/10 sha1_file: support lazily fetching missing objectsJeff Hostetler, Nov 21, 2017
  10. Christian CouderDec 2, 2017
  11. Jeff HostetlerDec 5, 2017
  12. 07/10 introduce fetch-object: fetch one promisor objectJeff Hostetler, Nov 21, 2017
  13. Christian CouderDec 2, 2017
  14. Jeff HostetlerDec 5, 2017
  15. 02/10 fsck: introduce partialclone extensionJeff Hostetler, Nov 21, 2017
  16. 03/10 fsck: support refs pointing to promisor objectsJeff Hostetler, Nov 21, 2017
  17. 06/10 index-pack: refactor writing of .keep filesJeff Hostetler, Nov 21, 2017
  18. Junio C HamanoNov 22, 2017
  19. Jonathan TanNov 22, 2017
  20. Jonathan TanNov 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.