From: Christian Couder <christian.couder@gmail.com>
Date: Sat, 02 Dec 2017 17:39:38 GMT
Subject: Re: [PATCH v5 10/10] gc: do not repack promisor packfiles
Message-ID: <CAP8UFD10YsCQtiFtLtzQ-PKsY93QaDC4zsO+k1tfauBs8ntt1w@mail.gmail.com>
In-Reply-To: <20171121210720.21376-11-git@jeffhostetler.com>

On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler <git@jeffhostetler.com> wrote:
> From: Jonathan Tan <jonathantanmy@google.com>

>  pack_as_from_promisor () {
>         HASH=$(git -C repo pack-objects .git/objects/pack/pack) &&
>         >repo/.git/objects/pack/pack-$HASH.promisor
> +       echo $HASH
>  }

Now the exit code of the above function will always be the exit code
of "echo $HASH".
It seems to me that it would be better to add "&&" at the end of the
line above the "echo $HASH".