Re: [PATCH v5 00/10] Partial clone part 2: fsck and promisors

From: Jonathan Tan <jonathantanmy@google.com>
Date: Nov 22, 2017, 18:00 UTC
Message-ID: <20171122100014.937f5902c3714e6e26e20a1b@google.com>
In-Reply-To: <xmqqy3myubpi.fsf@gitster.mtv.corp.google.com>

On Wed, 22 Nov 2017 14:25:13 +0900 Junio C Hamano <gitster@pobox.com> wrote:

Show 16 quoted lines

> Jeff Hostetler <git@jeffhostetler.com> writes:
> 
> > From: Jeff Hostetler <jeffhost@microsoft.com>
> >
> > This is V5 of part 2 of partial clone.  This assumes V5 of part 1
> > is already present.  V5 includes minor cleanup over V4 and better
> > separates the --exclude-promisor-objects and --missing arguments.
> >
> > Part 2 is concerned with fsck, gc, initial support for dynamic
> > object fetching, and tracking promisor objects.  Jonathan Tan
> > originally developed this code.  I have moved it on top of
> > part 1 and updated it slightly.
> 
> Thanks, will replace/queue all three series.  I am getting a feeling
> that the first one is already ready for 'next', while the other two
> may want to see a bit more comments?

Yes, I think so too.

Jeff Hostetler and I noticed some issues occuring when some other Git commands dynamically fetch objects due to the fact that those commands and fetch-pack use overlapping object flags. At the very least, we should look at that before it goes into next.