Re: [PATCH v5 00/10] Partial clone part 2: fsck and promisors
- From
- Jonathan Tan <jonathantanmy@google.com>
- Date
- Nov 22, 2017, 21:42 UTC
- Message-ID
- <CAGf8dg+UQ7eRxcBNJkzr_tZFMYxO-z4Z5Emi1HefEhtqJebe6Q@mail.gmail.com>
- In-Reply-To
- <20171122100014.937f5902c3714e6e26e20a1b@google.com>
On Wed, Nov 22, 2017 at 10:00 AM, Jonathan Tan <jonathantanmy@google.com> wrote:
Show 13 quoted lines
> On Wed, 22 Nov 2017 14:25:13 +0900 > Junio C Hamano <gitster@pobox.com> wrote: > >> Thanks, will replace/queue all three series. I am getting a feeling >> that the first one is already ready for 'next', while the other two >> may want to see a bit more comments? > > Yes, I think so too. > > Jeff Hostetler and I noticed some issues occuring when some other Git > commands dynamically fetch objects due to the fact that those commands > and fetch-pack use overlapping object flags. At the very least, we > should look at that before it goes into next.
In the end, making fetch-pack refrain from setting object flags when being used to dynamically fetch objects works (see the new "introduce fetch-object: fetch one promisor object" commit that I just pushed to [1]). I'll coordinate with Jeff Hostetler about sending v6 to the list (most likely after the U.S. Thanksgiving holidays).
[1] https://github.com/jonathantanmy/git/commits/pc20171122