Re: [PATCH 1/1] Mark messages for translations

From: Alexander Shopov <ash@kambanaria.org>
Date: Feb 12, 2018, 15:03 UTC
Message-ID: <CAP6f5MnjhyP+Ty4zqS3sP2mgYfK3RiKm3=YpFE3LABxx7nUBkw@mail.gmail.com>
In-Reply-To: <20180209193039.GA15554@sigill.intra.peff.net>

Let me repeat what you said so I know how to improve the patch: @Junio:

> Perhaps end each sentence with a full-stop?

I should end each sentence in the *log* message with "." (rather than the translatable strings in the patch)

> Shouldn't this rather be like so instead?
> if test_i18ngrep ! "invalid gitfile format" .err

...

> These two ones want to be written

The standard negation form is:
   test_i18ngrep !
but I should leave the `!` in front of `test_i18ngrep` in this particular case

@Jeff:

> we may want to avoid this anti-pattern

Current state of these tests is wrong and I should rework them.

Here is what I intend to do:
1. Fix the commit message
2. Check whether I can get the tests in t0002-gitfile.sh to the
standard `test_i18ngrep !` negative (i.e. without using `if`)
3. Post and ask for feedback again

Kind regards: al_shopov