Re: [PATCH 1/1] Mark messages for translations

From: Jeff King <peff@peff.net>
Date: Feb 12, 2018, 15:15 UTC
Message-ID: <20180212151500.GA21208@sigill.intra.peff.net>
In-Reply-To: <CAP6f5MnjhyP+Ty4zqS3sP2mgYfK3RiKm3=YpFE3LABxx7nUBkw@mail.gmail.com>

On Mon, Feb 12, 2018 at 04:03:49PM +0100, Alexander Shopov wrote:

Show 9 quoted lines

> @Jeff:
> > we may want to avoid this anti-pattern
> Current state of these tests is wrong and I should rework them.
> 
> Here is what I intend to do:
> 1. Fix the commit message
> 2. Check whether I can get the tests in t0002-gitfile.sh to the
> standard `test_i18ngrep !` negative (i.e. without using `if`)
> 3. Post and ask for feedback again

See the patch I posted earlier. For (2), "test_i18ngrep !" would be the wrong thing. I think you should either:

  - keep your patch as-is, and let Junio resolve the conflict when the
    two are merged

  - rebase your patch on top of mine. That's slightly less work for
    Junio, but it means that your topic cannot graduate until mine does
    (though hopefully mine is pretty non-controversial).

I'd probably just do the first in your place, since the conflict is easy to resolve.

-Peff