Re: [PATCH 1/1] Mark messages for translations

From: Jeff King <peff@peff.net>
Date: Feb 6, 2018, 07:38 UTC
Message-ID: <20180206073812.GA14133@sigill.intra.peff.net>
In-Reply-To: <CAPig+cSOgNfz+cYdcvsbbaf74RB0QNnmqLs9Ld9xdmarMaqzEQ@mail.gmail.com>

On Tue, Feb 06, 2018 at 02:32:42AM -0500, Eric Sunshine wrote:

Show 11 quoted lines

> > diff --git a/t/t0002-gitfile.sh b/t/t0002-gitfile.sh
> > @@ -31,7 +31,7 @@ test_expect_success 'bad setup: invalid .git file format' '
> >                 echo "git rev-parse accepted an invalid .git file"
> >                 false
> >         fi &&
> > -       if ! grep "Invalid gitfile format" .err
> > +       if ! grep "invalid gitfile format" .err
> 
> Since these strings can now be translated, you'll probably need to use
> 'test_i18ngrep' rather than 'grep'. (See test_i18ngrep in
> t/test-lib.sh.)

Good catch. Looks like there's another in t1506, which you can see with "make GETTEXT_POISON=1 test".

-Peff