git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/5] fsck: order 'fsck_msg_type' alphabetically

From
Karthik Nayak <karthik.188@gmail.com>
Date
Sep 8, 2025, 13:00 UTC
Message-ID
<CAOLa=ZTuZ3fOr_wkQ7TsEVRKjKynei4uF18YHygpcafXT9Qjmw@mail.gmail.com>
In-Reply-To
<xmqqwm6gh4q3.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 33 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> The list of 'fsck_msg_type' seem to be alphabetically ordered, but there
>> are a few small misses. Fix this by sorting the sub-sections of the
>> list to maintain alphabetical ordering. Also fix a clang-format issue
>> where the escaped newlines are not aligned.
>>
>> While here, remove a duplicate instance of 'gitmodulesLarge' in the
>> 'fsck-msgids' documentation.
>
> "A few small misses".
>
>> diff --git a/fsck.h b/fsck.h
>> index dd7df3d5b3..559ad57807 100644
>> --- a/fsck.h
>> +++ b/fsck.h
>> @@ -20,82 +20,82 @@ enum fsck_msg_type {
>> ...
>> -#define FOREACH_FSCK_MSG_ID(FUNC) \
>> -	/* fatal errors */ \
>> -	FUNC(NUL_IN_HEADER, FATAL) \
>> -	FUNC(UNTERMINATED_HEADER, FATAL) \
>> ...
>> +#define FOREACH_FSCK_MSG_ID(FUNC)                                  \
>> +	/* fatal errors */                                         \
>> +	FUNC(NUL_IN_HEADER, FATAL)                                 \
>> +	FUNC(UNTERMINATED_HEADER, FATAL)                           \
>> ...
>
> Please undo these "pad by spaces before backslash"; otherwise we
> cannot tell which ones are "a few small misses".
>
> Thanks.

Yeah, you're right, its much harder to review this way. Let me add in a commit at the end to do the clang-formatting for this section, that way we can drop it if it is too much noise.

- Karthik
Previous: Junio C HamanoNext: Karthik Nayak
Message 4 of 18 in “refs/reftable: add fsck checks”
  1. 0/5 refs/reftable: add fsck checksKarthik Nayak, Sep 2, 2025
  2. 1/5 fsck: order 'fsck_msg_type' alphabeticallyKarthik Nayak, Sep 2, 2025
  3. Junio C HamanoSep 2, 2025
  4. Karthik NayakSep 8, 2025
  5. 2/5 refs/reftable: add fsck check for checking the table nameKarthik Nayak, Sep 2, 2025
  6. Patrick SteinhardtSep 3, 2025
  7. shejialuoSep 3, 2025
  8. Karthik NayakSep 9, 2025
  9. Karthik NayakSep 9, 2025
  10. 3/5 refs/reftable: add fsck check for number of tablesKarthik Nayak, Sep 2, 2025
  11. Patrick SteinhardtSep 3, 2025
  12. Karthik NayakSep 15, 2025
  13. 4/5 refs/reftable: add fsck check for trailing newlineKarthik Nayak, Sep 2, 2025
  14. Junio C HamanoSep 2, 2025
  15. Patrick SteinhardtSep 3, 2025
  16. 5/5 refs/reftable: add fsck check for incorrect update indexKarthik Nayak, Sep 2, 2025
  17. Junio C HamanoSep 2, 2025
  18. Karthik NayakSep 18, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.