Re: [PATCH v2 3/5] refs/reftable: add fsck check for number of tables

From: Patrick Steinhardt <ps@pks.im>
Date: Sep 3, 2025, 08:07 UTC
Message-ID: <aLf3NyodTZ38N8vY@pks.im>
In-Reply-To: <20250902-228-reftable-introduce-consistency-checks-v2-3-4f96b3834779@gmail.com>

On Tue, Sep 02, 2025 at 09:05:23AM +0200, Karthik Nayak wrote:

Show 5 quoted lines

> Introduce a reftable fsck check to check that the number of files in the
> reftable directory matches the number of files listed in 'tables.list'.
> We do this by iterating over the files in the reftable directory and
> counting all the files present excluding the 'tables.list'. This is also
> exposed over Git's fsck checks as a 'badReftableStackCount' error.

This feels overly strict, as it can always be the case that a concurrent process is currently updating the stack. Furthermore, it's expected that on Windows systems deletion of an old table may not work because the file is still kept open by another process. The reftable library is prepared to handle this alright and will re-try deleting the table at a later point in time.

So maybe a better check would be to verify that there are no files with unexpected names in the directory?

Patrick