From: Karthik Nayak <karthik.188@gmail.com>
Date: Mon, 08 Sep 2025 13:00:51 GMT
Subject: Re: [PATCH v2 1/5] fsck: order 'fsck_msg_type' alphabetically
Message-ID: <CAOLa=ZTuZ3fOr_wkQ7TsEVRKjKynei4uF18YHygpcafXT9Qjmw@mail.gmail.com>
In-Reply-To: <xmqqwm6gh4q3.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> The list of 'fsck_msg_type' seem to be alphabetically ordered, but there
>> are a few small misses. Fix this by sorting the sub-sections of the
>> list to maintain alphabetical ordering. Also fix a clang-format issue
>> where the escaped newlines are not aligned.
>>
>> While here, remove a duplicate instance of 'gitmodulesLarge' in the
>> 'fsck-msgids' documentation.
>
> "A few small misses".
>
>> diff --git a/fsck.h b/fsck.h
>> index dd7df3d5b3..559ad57807 100644
>> --- a/fsck.h
>> +++ b/fsck.h
>> @@ -20,82 +20,82 @@ enum fsck_msg_type {
>> ...
>> -#define FOREACH_FSCK_MSG_ID(FUNC) \
>> -	/* fatal errors */ \
>> -	FUNC(NUL_IN_HEADER, FATAL) \
>> -	FUNC(UNTERMINATED_HEADER, FATAL) \
>> ...
>> +#define FOREACH_FSCK_MSG_ID(FUNC)                                  \
>> +	/* fatal errors */                                         \
>> +	FUNC(NUL_IN_HEADER, FATAL)                                 \
>> +	FUNC(UNTERMINATED_HEADER, FATAL)                           \
>> ...
>
> Please undo these "pad by spaces before backslash"; otherwise we
> cannot tell which ones are "a few small misses".
>
> Thanks.

Yeah, you're right, its much harder to review this way. Let me add in a
commit at the end to do the clang-formatting for this section, that way
we can drop it if it is too much noise.

- Karthik