git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 5/5] refs/reftable: add fsck check for incorrect update index

From
Karthik Nayak <karthik.188@gmail.com>
Date
Sep 18, 2025, 08:11 UTC
Message-ID
<CAOLa=ZTR0X+Za-8O04+6GzSUK83GUwaHTaWij3MA0vty2WUJUg@mail.gmail.com>
In-Reply-To
<xmqqo6rsh3xw.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 20 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> Introduce a fsck check for the reftable backend, which checks if the
>> tables in 'tables.list' contain sequential update index. The tables in
>> the reftable backend should contain sequential update index. This fsck
>> check ensures that.
>>
>> We must note that the reftable backend itself doesn't check to ensure
>> this and it also doesn't check to ensure that the index in the table
>> name matches the index in the header or the table. The latter is not
>> implemented in this fsck check either and will be added in a future
>> patch where we add fsck checks for internals of a table.
>
> Similar to the previous step, I am not sure why this should not be
> checked at runtime and is flagged as an error.
>
> In general, we do try to avoid retroactively tightening rules, but
> the reftable is so new and not even the default.  If we noticed that
> the runtime has been overly loose, the time to tighten it is now,
> not after even more installations use it.

I think your point is fair and I agree. I did consider it, but didn't want to 'retroactively tightening rules'. But I think it is justified, more so since we're not introducing any changes on the format, but just more validation around it.

I should've replied here sooner, but I didn't ever get to it. I found some time to finally fix the comments from this series and will send in a new version. I will be more diligent about it here on.

- Karthik
Previous: Junio C Hamano
Message 18 of 18 in “refs/reftable: add fsck checks”
  1. 0/5 refs/reftable: add fsck checksKarthik Nayak, Sep 2, 2025
  2. 1/5 fsck: order 'fsck_msg_type' alphabeticallyKarthik Nayak, Sep 2, 2025
  3. Junio C HamanoSep 2, 2025
  4. Karthik NayakSep 8, 2025
  5. 2/5 refs/reftable: add fsck check for checking the table nameKarthik Nayak, Sep 2, 2025
  6. Patrick SteinhardtSep 3, 2025
  7. shejialuoSep 3, 2025
  8. Karthik NayakSep 9, 2025
  9. Karthik NayakSep 9, 2025
  10. 3/5 refs/reftable: add fsck check for number of tablesKarthik Nayak, Sep 2, 2025
  11. Patrick SteinhardtSep 3, 2025
  12. Karthik NayakSep 15, 2025
  13. 4/5 refs/reftable: add fsck check for trailing newlineKarthik Nayak, Sep 2, 2025
  14. Junio C HamanoSep 2, 2025
  15. Patrick SteinhardtSep 3, 2025
  16. 5/5 refs/reftable: add fsck check for incorrect update indexKarthik Nayak, Sep 2, 2025
  17. Junio C HamanoSep 2, 2025
  18. Karthik NayakSep 18, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.