git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 05/11] ref-filter: add parse_opt_merge_filter()

From
karthik nayak <karthik.188@gmail.com>
Date
Jun 16, 2015, 16:30 UTC
Message-ID
<CAOLa=ZS_gY-MuGJ86TFpHhMXNYJ1gHWQWyfv71gDCVm1sMXZNw@mail.gmail.com>
In-Reply-To
<vpqmvzz7hjq.fsf@anie.imag.fr>

On Tue, Jun 16, 2015 at 9:48 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 17 quoted lines
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> This is copied from 'builtin/branch.c' which will eventually be removed
>> when we port 'branch.c' to use ref-filter APIs.
>
> Earlier in the series you took code from tag.c.
>
> I think you should focus on either merge or tag, get a ref-filter-based
> replacement that passes the tests for it, and then consider the other.
> The fact that the test pass for a rewritten command is important to
> check the correctness of the these patches.
>
> I'm not asking you to remove commits from this series though. Just
> impatient to see one command fully replaced (actually, I see that you
> have more commits than you sent in your branch, so I guess it will come
> soon on the list) :-).
>

The idea is to currently get ref-filter to support all options and port it over to for-each-ref which would be the first command to completely use ref-filter.

And like you said, the challenge is to then ensure tag.c and branch.c to use ref-filter and make them pass all tests.

If you see my branch on Github, I have been pushing patches to port tag.c to use ref-filter. I just finish porting tag.c to use ref-filter. Now to include missing options in it, then I'll push the series to the list. (Must be quite a co-incidence cause I just pushed a patch for tag.c to completely use ref-filter )

Like you mentioned tag.c and branch.c both have their own setup for which small changes need to be made in ref-filter. So taking one step at a time, I'll finish up with tag.c and end it with branch.c

-- 
Regards,
Karthik Nayak
Previous: Matthieu MoyNext: Matthieu Moy
Message 10 of 23 in “add options to for-each-ref”
  1. 00/11 add options to for-each-refkarthik nayak, Jun 16, 2015
  2. 01/11 t6301: for-each-ref tests for ref-filter APIsKarthik Nayak, Jun 16, 2015
  3. 02/11 tag: libify parse_opt_points_at()Karthik Nayak, Jun 16, 2015
  4. 03/11 ref-filter: implement '--points-at' optionKarthik Nayak, Jun 16, 2015
  5. 04/11 for-each-ref: add '--points-at' optionKarthik Nayak, Jun 16, 2015
  6. Matthieu MoyJun 16, 2015
  7. karthik nayakJun 16, 2015
  8. 05/11 ref-filter: add parse_opt_merge_filter()Karthik Nayak, Jun 16, 2015
  9. Matthieu MoyJun 16, 2015
  10. karthik nayakJun 16, 2015
  11. Matthieu MoyJun 17, 2015
  12. karthik nayakJun 17, 2015
  13. 06/11 ref-filter: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jun 16, 2015
  14. Matthieu MoyJun 17, 2015
  15. karthik nayakJun 17, 2015
  16. 07/11 for-each-ref: add '--merged' and '--no-merged' optionsKarthik Nayak, Jun 16, 2015
  17. 08/11 parse-option: rename parse_opt_with_commit()Karthik Nayak, Jun 16, 2015
  18. 09/11 parse-options.h: add macros for '--contains' optionKarthik Nayak, Jun 16, 2015
  19. 10/11 ref-filter: implement '--contains' optionKarthik Nayak, Jun 16, 2015
  20. 11/11 for-each-ref: add '--contains' optionKarthik Nayak, Jun 16, 2015
  21. Matthieu MoyJun 17, 2015
  22. Matthieu MoyJun 16, 2015
  23. karthik nayakJun 16, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.