git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 01/11] t6301: for-each-ref tests for ref-filter APIs

From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date
Jun 16, 2015, 15:21 UTC
Message-ID
<vpqmvzz8yr4.fsf@anie.imag.fr>
In-Reply-To
<1434464457-10749-1-git-send-email-karthik.188@gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
> Add tests for 'for-each-ref' which utilizes the ref-filter APIs.
> Currently it's redundant with the tests in 't6300' but more tests
> will be eventually added as we implement more options into
> 'for-each-ref'.

Actually, I'm not convinced that the actual tests have a real value (since as you say, it's redundant with t6300). Perhaps we can limit this commit to the setup.

Show 8 quoted lines
> +++ b/t/t6301-for-each-ref-filter.sh
> @@ -0,0 +1,36 @@
> +#!/bin/sh
> +
> +test_description='test for-each-refs usage of ref-filter APIs'
> +
> +. ./test-lib.sh
> +. "$TEST_DIRECTORY"/lib-gpg.sh
You are not using lib-gpg.sh, right?

If first thought it was an incorrect cut-and-paste, but I actually think that you need to setup a signed tag to properly test the --points-at option (it does not only list refs pointing directly at a commit, but also refs pointing at a tag pointing at the given commit).

Such signed tag could be added here and used later in PATCH 04.
-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Previous: Matthieu MoyNext: karthik nayak
Message 22 of 23 in “add options to for-each-ref”
  1. 00/11 add options to for-each-refkarthik nayak, Jun 16, 2015
  2. 01/11 t6301: for-each-ref tests for ref-filter APIsKarthik Nayak, Jun 16, 2015
  3. 02/11 tag: libify parse_opt_points_at()Karthik Nayak, Jun 16, 2015
  4. 03/11 ref-filter: implement '--points-at' optionKarthik Nayak, Jun 16, 2015
  5. 04/11 for-each-ref: add '--points-at' optionKarthik Nayak, Jun 16, 2015
  6. Matthieu MoyJun 16, 2015
  7. karthik nayakJun 16, 2015
  8. 05/11 ref-filter: add parse_opt_merge_filter()Karthik Nayak, Jun 16, 2015
  9. Matthieu MoyJun 16, 2015
  10. karthik nayakJun 16, 2015
  11. Matthieu MoyJun 17, 2015
  12. karthik nayakJun 17, 2015
  13. 06/11 ref-filter: implement '--merged' and '--no-merged' optionsKarthik Nayak, Jun 16, 2015
  14. Matthieu MoyJun 17, 2015
  15. karthik nayakJun 17, 2015
  16. 07/11 for-each-ref: add '--merged' and '--no-merged' optionsKarthik Nayak, Jun 16, 2015
  17. 08/11 parse-option: rename parse_opt_with_commit()Karthik Nayak, Jun 16, 2015
  18. 09/11 parse-options.h: add macros for '--contains' optionKarthik Nayak, Jun 16, 2015
  19. 10/11 ref-filter: implement '--contains' optionKarthik Nayak, Jun 16, 2015
  20. 11/11 for-each-ref: add '--contains' optionKarthik Nayak, Jun 16, 2015
  21. Matthieu MoyJun 17, 2015
  22. Matthieu MoyJun 16, 2015
  23. karthik nayakJun 16, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.