From: karthik nayak Date: Tue, 16 Jun 2015 16:30:20 GMT Subject: Re: [PATCH v3 05/11] ref-filter: add parse_opt_merge_filter() Message-ID: In-Reply-To: On Tue, Jun 16, 2015 at 9:48 PM, Matthieu Moy wrote: > Karthik Nayak writes: > >> This is copied from 'builtin/branch.c' which will eventually be removed >> when we port 'branch.c' to use ref-filter APIs. > > Earlier in the series you took code from tag.c. > > I think you should focus on either merge or tag, get a ref-filter-based > replacement that passes the tests for it, and then consider the other. > The fact that the test pass for a rewritten command is important to > check the correctness of the these patches. > > I'm not asking you to remove commits from this series though. Just > impatient to see one command fully replaced (actually, I see that you > have more commits than you sent in your branch, so I guess it will come > soon on the list) :-). > The idea is to currently get ref-filter to support all options and port it over to for-each-ref which would be the first command to completely use ref-filter. And like you said, the challenge is to then ensure tag.c and branch.c to use ref-filter and make them pass all tests. If you see my branch on Github, I have been pushing patches to port tag.c to use ref-filter. I just finish porting tag.c to use ref-filter. Now to include missing options in it, then I'll push the series to the list. (Must be quite a co-incidence cause I just pushed a patch for tag.c to completely use ref-filter ) Like you mentioned tag.c and branch.c both have their own setup for which small changes need to be made in ref-filter. So taking one step at a time, I'll finish up with tag.c and end it with branch.c -- Regards, Karthik Nayak