Re: [PATCH 03/18] setup: stop using `the_repository` in `is_inside_git_dir()`
- From
Karthik Nayak <karthik.188@gmail.com>
- Date
- Apr 9, 2026, 12:58 UTC
- Message-ID
- <CAOLa=ZS-bHiG0wyjwfzSbX4TgC_Jfpk2NXHAf=dUm6CvVxx80Q@mail.gmail.com>
- In-Reply-To
- <20260330-pks-setup-wo-the-repository-v1-3-0d2e822837aa@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 5 quoted lines
> Similar as with the preceding commit, `is_inside_git_dir()` determines > whether the current working directory is located inside the gitdir of > `the_repository`. Perform the same refactoring by dropping the caching > mechanism and injecting the repository that shall be checked. >
The patch looks good. I do wonder if these functions need a new home, 'setup.c' is fine, but it is also bloated.