git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 03/18] setup: stop using `the_repository` in `is_inside_git_dir()`

From
Patrick Steinhardt <ps@pks.im>
Date
Apr 13, 2026, 05:47 UTC
Message-ID
<adyDiEW0-wRlgp6E@pks.im>
In-Reply-To
<CAOLa=ZS-bHiG0wyjwfzSbX4TgC_Jfpk2NXHAf=dUm6CvVxx80Q@mail.gmail.com>
On Thu, Apr 09, 2026 at 08:58:03AM -0400, Karthik Nayak wrote:
Show 10 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Similar as with the preceding commit, `is_inside_git_dir()` determines
> > whether the current working directory is located inside the gitdir of
> > `the_repository`. Perform the same refactoring by dropping the caching
> > mechanism and injecting the repository that shall be checked.
> >
> 
> The patch looks good. I do wonder if these functions need a new home,
> 'setup.c' is fine, but it is also bloated.

I agree that they don't really make a ton of sense in "setup.c". In general, I would love to split up that file into two pieces:

  - The pieces required to detect a repository and discover its exact
    configuration. So scanning the current working directory and its
    parent directories, paying attention to environment variables, and
    detecting the repository format.
  - The pieces required to configure the repository based on the
    findings.

I would really like to completely detangle these two things from one another so that the detection logic will basically just give us a structure that contains all relevant information. And that info can then be passed into "repository.c" to create a new repository for us based on the info.

This would unlock a couple of benefits:
  - Creating a repository will become "pure", as we only depend on
    passed-in info and not on the environment anymore.
  - We can unify the creation of a repository into, instead of having
    roughly the same logic in both "setup.c" and "repository.c".
  - We can remove some logic that essentially re-configures a repo
    multiple times as we currently do in "setup.c", which should lead to
    a much cleaner design.

This is already thinking ahead quite a bit though. The next step would be to de-globalize some other functionality in "setup.c" first in the next patch series. But afterwards I'd indeed like to tackle this problem in the subsequent step.

Thanks!
Patrick
Previous: Karthik NayakNext: Junio C Hamano
Message 7 of 31 in “setup: drop uses of `the_repository`”
  1. 00/18 setup: drop uses of `the_repository`Patrick Steinhardt, Mar 30, 2026
  2. 01/18 setup: replace use of `the_repository` in static functionsPatrick Steinhardt, Mar 30, 2026
  3. 02/18 setup: stop using `the_repository` in `is_inside_worktree()`Patrick Steinhardt, Mar 30, 2026
  4. Karthik NayakApr 9, 2026
  5. 03/18 setup: stop using `the_repository` in `is_inside_git_dir()`Patrick Steinhardt, Mar 30, 2026
  6. Karthik NayakApr 9, 2026
  7. Patrick SteinhardtApr 13, 2026
  8. Junio C HamanoApr 13, 2026
  9. 04/18 setup: stop using `the_repository` in `prefix_path()`Patrick Steinhardt, Mar 30, 2026
  10. 05/18 setup: stop using `the_repository` in `path_inside_repo()`Patrick Steinhardt, Mar 30, 2026
  11. 06/18 setup: stop using `the_repository` in `verify_filename()`Patrick Steinhardt, Mar 30, 2026
  12. 07/18 setup: stop using `the_repository` in `verify_non_filename()`Patrick Steinhardt, Mar 30, 2026
  13. 08/18 setup: stop using `the_repository` in `enter_repo()`Patrick Steinhardt, Mar 30, 2026
  14. 09/18 setup: stop using `the_repository` in `setup_work_tree()`Patrick Steinhardt, Mar 30, 2026
  15. Elijah NewrenApr 18, 2026
  16. Patrick SteinhardtApr 20, 2026
  17. 10/18 setup: stop using `the_repository` in `set_git_work_tree()`Patrick Steinhardt, Mar 30, 2026
  18. Elijah NewrenApr 18, 2026
  19. Patrick SteinhardtApr 20, 2026
  20. 11/18 setup: stop using `the_repository` in `setup_git_env()`Patrick Steinhardt, Mar 30, 2026
  21. 12/18 setup: stop using `the_repository` in `setup_git_directory_gently()`Patrick Steinhardt, Mar 30, 2026
  22. 13/18 setup: stop using `the_repository` in `setup_git_directory()`Patrick Steinhardt, Mar 30, 2026
  23. 14/18 setup: stop using `the_repository` in `upgrade_repository_format()`Patrick Steinhardt, Mar 30, 2026
  24. 15/18 setup: stop using `the_repository` in `check_repository_format()`Patrick Steinhardt, Mar 30, 2026
  25. Elijah NewrenApr 18, 2026
  26. Patrick SteinhardtApr 20, 2026
  27. 16/18 setup: stop using `the_repository` in `initialize_repository_version()`Patrick Steinhardt, Mar 30, 2026
  28. 17/18 setup: stop using `the_repository` in `create_reference_database()`Patrick Steinhardt, Mar 30, 2026
  29. 18/18 setup: stop using `the_repository` in `init_db()`Patrick Steinhardt, Mar 30, 2026
  30. Karthik NayakApr 9, 2026
  31. Patrick SteinhardtApr 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.