git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 15/18] setup: stop using `the_repository` in `check_repository_format()`

From
Elijah Newren <newren@gmail.com>
Date
Apr 18, 2026, 01:23 UTC
Message-ID
<CABPp-BGHvWxX=g6hT_PKwAwjCAhiz3xOGh9vnWstWcEtyf4sHA@mail.gmail.com>
In-Reply-To
<20260330-pks-setup-wo-the-repository-v1-15-0d2e822837aa@pks.im>
On Mon, Mar 30, 2026 at 6:19 AM Patrick Steinhardt <ps@pks.im> wrote:
Show 26 quoted lines
>
> Stop using `the_repository` in `check_repository_format()` and instead
> accept the repository as a parameter. The injection of `the_repository`
> is thus bumped one level higher, where callers now pass it in
> explicitly.
>
> Furthermore, the function is never used outside "setup.c". Drop its
> declaration in "setup.h" and make it static. Note that this requires us
> to reorder the function.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  setup.c | 58 +++++++++++++++++++++++++++++++++-------------------------
>  setup.h | 10 ----------
>  2 files changed, 33 insertions(+), 35 deletions(-)
>
> diff --git a/setup.c b/setup.c
> index 6dbd096f20..c32d6e96bb 100644
> --- a/setup.c
> +++ b/setup.c
> @@ -1755,6 +1755,37 @@ enum discovery_result discover_git_directory_reason(struct strbuf *commondir,
>         return result;
>  }
>
> +/*
> + * Check the repository format version in the path found in repo_get_git_dir(the_repository),
Can we make the code comment match the code below, i.e.
   the_repository -> repo
?
Show 12 quoted lines
> + * and die if it is a version we don't understand. Generally one would
> + * set_git_dir() before calling this, and use it only for "are we in a valid
> + * repo?".
> + *
> + * If successful and fmt is not NULL, fill fmt with data.
> + */
> +static void check_repository_format(struct repository *repo, struct repository_format *fmt)
> +{
> +       struct repository_format repo_fmt = REPOSITORY_FORMAT_INIT;
> +       if (!fmt)
> +               fmt = &repo_fmt;
> +       check_repository_format_gently(repo, repo_get_git_dir(repo), fmt, NULL);
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 25 of 31 in “setup: drop uses of `the_repository`”
  1. 00/18 setup: drop uses of `the_repository`Patrick Steinhardt, Mar 30, 2026
  2. 01/18 setup: replace use of `the_repository` in static functionsPatrick Steinhardt, Mar 30, 2026
  3. 02/18 setup: stop using `the_repository` in `is_inside_worktree()`Patrick Steinhardt, Mar 30, 2026
  4. Karthik NayakApr 9, 2026
  5. 03/18 setup: stop using `the_repository` in `is_inside_git_dir()`Patrick Steinhardt, Mar 30, 2026
  6. Karthik NayakApr 9, 2026
  7. Patrick SteinhardtApr 13, 2026
  8. Junio C HamanoApr 13, 2026
  9. 04/18 setup: stop using `the_repository` in `prefix_path()`Patrick Steinhardt, Mar 30, 2026
  10. 05/18 setup: stop using `the_repository` in `path_inside_repo()`Patrick Steinhardt, Mar 30, 2026
  11. 06/18 setup: stop using `the_repository` in `verify_filename()`Patrick Steinhardt, Mar 30, 2026
  12. 07/18 setup: stop using `the_repository` in `verify_non_filename()`Patrick Steinhardt, Mar 30, 2026
  13. 08/18 setup: stop using `the_repository` in `enter_repo()`Patrick Steinhardt, Mar 30, 2026
  14. 09/18 setup: stop using `the_repository` in `setup_work_tree()`Patrick Steinhardt, Mar 30, 2026
  15. Elijah NewrenApr 18, 2026
  16. Patrick SteinhardtApr 20, 2026
  17. 10/18 setup: stop using `the_repository` in `set_git_work_tree()`Patrick Steinhardt, Mar 30, 2026
  18. Elijah NewrenApr 18, 2026
  19. Patrick SteinhardtApr 20, 2026
  20. 11/18 setup: stop using `the_repository` in `setup_git_env()`Patrick Steinhardt, Mar 30, 2026
  21. 12/18 setup: stop using `the_repository` in `setup_git_directory_gently()`Patrick Steinhardt, Mar 30, 2026
  22. 13/18 setup: stop using `the_repository` in `setup_git_directory()`Patrick Steinhardt, Mar 30, 2026
  23. 14/18 setup: stop using `the_repository` in `upgrade_repository_format()`Patrick Steinhardt, Mar 30, 2026
  24. 15/18 setup: stop using `the_repository` in `check_repository_format()`Patrick Steinhardt, Mar 30, 2026
  25. Elijah NewrenApr 18, 2026
  26. Patrick SteinhardtApr 20, 2026
  27. 16/18 setup: stop using `the_repository` in `initialize_repository_version()`Patrick Steinhardt, Mar 30, 2026
  28. 17/18 setup: stop using `the_repository` in `create_reference_database()`Patrick Steinhardt, Mar 30, 2026
  29. 18/18 setup: stop using `the_repository` in `init_db()`Patrick Steinhardt, Mar 30, 2026
  30. Karthik NayakApr 9, 2026
  31. Patrick SteinhardtApr 13, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.