From: Karthik Nayak Date: Thu, 09 Apr 2026 12:58:03 GMT Subject: Re: [PATCH 03/18] setup: stop using `the_repository` in `is_inside_git_dir()` Message-ID: In-Reply-To: <20260330-pks-setup-wo-the-repository-v1-3-0d2e822837aa@pks.im> Patrick Steinhardt writes: > Similar as with the preceding commit, `is_inside_git_dir()` determines > whether the current working directory is located inside the gitdir of > `the_repository`. Perform the same refactoring by dropping the caching > mechanism and injecting the repository that shall be checked. > The patch looks good. I do wonder if these functions need a new home, 'setup.c' is fine, but it is also bloated.