Re: [RFC/PATCH v2 3/8] rebase: cherry-pick: fix sequence continuation

From: Martin von Zweigbergk <martinvonz@gmail.com>
Date: May 29, 2013, 05:51 UTC
Message-ID: <CANiSa6h7fY=GNM0VvFXvE-LD=nVWbEBGqWbaheZ6gr518_aPNA@mail.gmail.com>
In-Reply-To: <CAMP44s0Zy4KpPN1n6HOVXWyCuevenbSFnH589YngMB9NVWcamQ@mail.gmail.com>

On Tue, May 28, 2013 at 10:41 PM, Felipe Contreras <felipe.contreras@gmail.com> wrote:

Show 11 quoted lines

> On Wed, May 29, 2013 at 12:33 AM, Martin von Zweigbergk
> <martinvonz@gmail.com> wrote:
>>  As Junio asked in the previous iteration, shouldn't this have been in
>> the first patch?
>
> No, the first patch is splitting the code without introducing any
> functional changes.
>
> This is fixing a bug that already exists, we could fix it before the
> split, or after, but mixing the split and the fix at the same time is
> a no-no.

Oh, now I remember. I ran into that bug once.

> One change splits, the other change fixes, what's wrong with that?

I didn't say there was anything wrong. I was asking if the bug was there before (and I didn't see an answer when Junio asked).

Thanks