git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 3/3] Add colors to interactive git-clean

From
Jiang Xin <worldhello.net@gmail.com>
Date
May 3, 2013, 02:53 UTC
Message-ID
<CANYiYbG5r=sO7qqU4hnOpCUUrgVYPZH6XF7xO4+6TqCGTjC6pg@mail.gmail.com>
In-Reply-To
<vpqhailfmj9.fsf@grenoble-inp.fr>
2013/5/2 Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>:
Show 9 quoted lines
> Jiang Xin <worldhello.net@gmail.com> writes:
>
>> Show help, error messages, and prompt in colors for interactive
>> git-clean.
>
> I find the red WARNING a bit agressive. Also, the NOTE: is the same
> color as the WARNING, hence visually similar. I first thought it was
> repeating the same message. I think it would make more sense to use
> default color, black,

Will use new style -- CLEAN_COLOR_HEADER (GIT_COLOR_BOLD) as header for interactive git-clean (i.e. WARNING)

> for the NOTE, by analogy with "git add -p" which
> uses it for patch hunk headers (somehow, this is the question you're
> replying to after the blue prompt below).

I agree. NOTE should only be displayed once, and will be fixed in patch 3/1 of next reroll.

-- Jiang Xin

Previous: Matthieu MoyNext: Matthieu Moy
Message 26 of 30 in “clean: confirm before cleaning files and directories”
  1. clean: confirm before cleaning files and directoriesJiang Xin, Apr 26, 2013
  2. Matthieu MoyApr 26, 2013
  3. Jiang XinApr 26, 2013
  4. Matthieu MoyApr 26, 2013
  5. Jiang XinApr 26, 2013
  6. Thomas RastApr 26, 2013
  7. Junio C HamanoApr 26, 2013
  8. Matthieu MoyApr 26, 2013
  9. Junio C HamanoApr 26, 2013
  10. Junio C HamanoApr 26, 2013
  11. Jiang XinApr 27, 2013
  12. Add support for -i/--interactive to git-cleanJiang Xin, Apr 27, 2013
  13. Matthieu MoyApr 27, 2013
  14. Junio C HamanoApr 27, 2013
  15. Eric SunshineApr 28, 2013
  16. Matthieu MoyApr 29, 2013
  17. clean: Introduce -z for machine readable outputMichael J Gruber, Apr 29, 2013
  18. Matthieu MoyApr 29, 2013
  19. Jiang XinApr 29, 2013
  20. Add support for -i/--interactive to git-cleanJiang Xin, Apr 30, 2013
  21. Matthieu MoyMay 1, 2013
  22. 1/3 Add support for -i/--interactive to git-cleanJiang Xin, May 2, 2013
  23. 2/3 Show items of interactive git-clean in columnsJiang Xin, May 2, 2013
  24. 3/3 Add colors to interactive git-cleanJiang Xin, May 2, 2013
  25. Matthieu MoyMay 2, 2013
  26. Jiang XinMay 3, 2013
  27. Matthieu MoyMay 2, 2013
  28. Jiang XinMay 3, 2013
  29. Matthieu MoyMay 3, 2013
  30. Jiang XinMay 2, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.