From: Jiang Xin <worldhello.net@gmail.com>
Date: Fri, 03 May 2013 02:53:01 GMT
Subject: Re: [PATCH v4 3/3] Add colors to interactive git-clean
Message-ID: <CANYiYbG5r=sO7qqU4hnOpCUUrgVYPZH6XF7xO4+6TqCGTjC6pg@mail.gmail.com>
In-Reply-To: <vpqhailfmj9.fsf@grenoble-inp.fr>

2013/5/2 Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>:
> Jiang Xin <worldhello.net@gmail.com> writes:
>
>> Show help, error messages, and prompt in colors for interactive
>> git-clean.
>
> I find the red WARNING a bit agressive. Also, the NOTE: is the same
> color as the WARNING, hence visually similar. I first thought it was
> repeating the same message. I think it would make more sense to use
> default color, black,

Will use new style -- CLEAN_COLOR_HEADER (GIT_COLOR_BOLD)
as header for interactive git-clean (i.e.  WARNING)

> for the NOTE, by analogy with "git add -p" which
> uses it for patch hunk headers (somehow, this is the question you're
> replying to after the blue prompt below).

I agree. NOTE should only be displayed once, and will be fixed
in patch 3/1 of next reroll.

--
Jiang Xin