Re: [PATCH v4 2/3] Show items of interactive git-clean in columns

From: Jiang Xin <worldhello.net@gmail.com>
Date: May 3, 2013, 01:26 UTC
Message-ID: <CANYiYbGsMbJ=Ra6_fv12fnC_-Y5YfdWMgnROFWxo+Y=mkPKsiA@mail.gmail.com>
In-Reply-To: <vpqppx9fmpu.fsf@grenoble-inp.fr>

2013/5/2 Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>:

Show 5 quoted lines

> Jiang Xin <worldhello.net@gmail.com> writes:
>
>> Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
>
> This lacks a proper commit message (why is this a good thing?), and

Rewrite the log as following:

Show items of interactive git-clean in columns

When there are lots of items to be cleaned, it is hard to see them all in one screen. Show them in columns instead of in one column will solve this problem.

Since no longer show items to be cleaned using the "Would remove ..." format (only plain filenames), we add instructions/warnings as header before them.

> documentation (you introduce column.clean) but the code sounds good
> (that's a very quick look from me, not a "review" sorry).

Will honors column.ui config variable only, not introduce new config variable. So no more documentations needed ;-)

Fix-up looks like this:

 static int git_clean_config(const char *var, const char *value, void *cb)
 {
+       /* honors the column.ui config variable only */
        if (!prefixcmp(var, "column."))
-               return git_column_config(var, value, "clean", &colopts);
+               return git_column_config(var, value, NULL, &colopts);
        if (!strcmp(var, "color.interactive")) {
                clean_use_color = git_config_colorbool(var, value);
                return 0;

-- 
Jiang Xin