Re: [PATCH v4 3/3] Add colors to interactive git-clean
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- May 2, 2013, 15:07 UTC
- Message-ID
- <vpqhailfmj9.fsf@grenoble-inp.fr>
- In-Reply-To
- <bb5463fa4ef09df08ad3bf5abf4660a5df414e64.1367500374.git.worldhello.net@gmail.com>
Jiang Xin <worldhello.net@gmail.com> writes:
> Show help, error messages, and prompt in colors for interactive > git-clean.
I find the red WARNING a bit agressive. Also, the NOTE: is the same color as the WARNING, hence visually similar. I first thought it was repeating the same message. I think it would make more sense to use default color, black, for the NOTE, by analogy with "git add -p" which uses it for patch hunk headers (somehow, this is the question you're replying to after the blue prompt below).
-- Matthieu Moy http://www-verimag.imag.fr/~moy/