Show 18 quoted lines
>> -b|--binary)
>> - echo >&2 "The $1 option has been a no-op for long time, and"
>> - echo >&2 "it will be removed. Please do not use it anymore."
>> + echo >&2 $(gettext "The -b option has been a no-op for long time, and
>> +it will be removed. Please do not use it anymore.")
>
> ... that this changes the message when the --binary option is passed.
> Before this patch, it says
>
> The --binary option has been a no-op for a long time, and ...
>
> After the patch, it says
>
> The -b option has been a no-op for a long time, and ...
>
> Intentional? That may be a good change or a bad one (I haven't
> thought clearly about it), but it seems at least worth mentioning.
> Cc-ing Thomas in case he has advice.
It's intentional.
* First, if a variable in the message, we could not use gettext,
for the variable will be expanded (evaluated) and never match
the entry in po file.
* Second, if there is a positional parameter ($1, $2,...) in the
message, we could not use eval_gettext either. Because
eval_gettext may be a wapper for gettext, and the positional
parameter would loose it's original context.
Jiang Xin <worldhello.net@gmail.com>