Re: [PATCH v3 5/7] i18n: am: mark more strings for translation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 24, 2012, 20:43 UTC
- Message-ID
- <7vwr1sevpu.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20120724181600.GH2939@burratino>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 18 quoted lines
>> -b|--binary) >> - echo >&2 "The $1 option has been a no-op for long time, and" >> - echo >&2 "it will be removed. Please do not use it anymore." >> + echo >&2 $(gettext "The -b option has been a no-op for long time, and >> +it will be removed. Please do not use it anymore.") > > ... that this changes the message when the --binary option is passed. > Before this patch, it says > > The --binary option has been a no-op for a long time, and ... > > After the patch, it says > > The -b option has been a no-op for a long time, and ... > > Intentional? That may be a good change or a bad one (I haven't > thought clearly about it), but it seems at least worth mentioning. > Cc-ing Thomas in case he has advice.
If we really care we could printf $1, but I think we usually do
The -b/--binary option has been...
in a case like this, especially in codepaths that no longer has an easy access to $1 after parsing the command line but knows that either one of them is given from the parse result, and that would be an appropriate solution for this particular one as well.