Re: [PATCH v3 1/7] i18n: New keywords for xgettext extraction from sh
- From
Jonathan Nieder <jrnieder@gmail.com>
- Date
- Jul 24, 2012, 17:46 UTC
- Message-ID
- <20120724174656.GE2939@burratino>
- In-Reply-To
- <6fbf2661d428ca4c4227b418368716d903dfd3e3.1343112786.git.worldhello.net@gmail.com>
Jiang Xin wrote:
> Since we have additional shell wrappers (gettextln and eval_gettextln) > for gettext, we need to take into account these wrappers when run > 'make pot' to extract messages from shell scripts.
Yes, thanks for fixing it.
As Stefano mentioned, s/run/running/ would make the above clearer.
With or without that change, Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>