Re: [PATCH v3 6/7] Remove unused and bad gettext block from git-am

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 24, 2012, 21:21 UTC
Message-ID: <7vobn4etxx.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAOeW2eHyLHGs3-Sd6X0b2Of1mFa1U8dCBU7L85_MJc4BY=BJmA@mail.gmail.com>

Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:

Show 16 quoted lines

> On Tue, Jul 24, 2012 at 11:27 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Hi,
>>
>> Jiang Xin wrote:
>>
>>> Gettext message should not start with '-' nor '--'. Since the '-d' and
>>> '--dotest' options do not exist in OPTIONS_SPEC variable, it's safe to
>>> remove the block.
>>
>> The above justification is not a sufficient reason to stop giving
>> helpful advice when someone uses an option that was historically
>> supported:
>
> I think Jiang is saying that "git am --dotest=..." already errors out
> because "dotest" is not in the OPTIONS_SPEC. See 98ef23b (git-am:
> minor cleanups, 2009-01-28). Or am I missing something?

No you are not missing anything, I would think.