git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] git-column.txt: fix section header

From
MÅMartin Ågren <martin.agren@gmail.com>
Date
Dec 16, 2018, 14:27 UTC
Message-ID
<CAN0heSrsZy-pKGu+x2KnNKCnhVtJm9eYJxYFVirxAe7JL6+39A@mail.gmail.com>
In-Reply-To
<20181216105123.GD13704@sigill.intra.peff.net>
On Sun, 16 Dec 2018 at 11:51, Jeff King <peff@peff.net> wrote:
Show 16 quoted lines
>
> On Sat, Dec 15, 2018 at 12:27:39PM +0100, Martin Ågren wrote:
>
> > We have too few dashes under "Examples", which causes Asciidoctor to not
> > pick it up as a section header, but to instead just render the dashes
> > literally. This also seems to confuse Asciidoctor about dashes in
> > general around here. It misinterprets the listing blocks in this
> > section, again rendering the dashes literally.
> >
> > Make sure we have as many dashes as we have characters in "Examples".
> > This fixes the section-issue and, somehow, makes the listing blocks
> > render correctly.
>
> The "somehow" here is that the mismatched dashes appear to be the start
> of a code listing block, making the whole example section into one big
> listing (which isn't properly closed, generating a warning).

Of course. Thanks for pointing it out. I now realize that when I wrote "render the dashes literally", I was wrong.

This should be improved in v2.
Martin
Previous: Jeff KingNext: Martin Ågren
Message 4 of 18 in “A few Asciidoctor-fixes”
  1. 0/4 A few Asciidoctor-fixesMartin Ågren, Dec 15, 2018
  2. 1/4 git-column.txt: fix section headerMartin Ågren, Dec 15, 2018
  3. Jeff KingDec 16, 2018
  4. Martin ÅgrenDec 16, 2018
  5. 2/4 git-init.txt: do not nest open blocksMartin Ågren, Dec 15, 2018
  6. Jeff KingDec 16, 2018
  7. 3/4 rev-list-options.txt: do not nest open blocksMartin Ågren, Dec 15, 2018
  8. Jeff KingDec 16, 2018
  9. 4/4 git-status.txt: render tables correctly under AsciidoctorMartin Ågren, Dec 15, 2018
  10. Jeff KingDec 16, 2018
  11. 0/3 A few Asciidoctor-fixesMartin Ågren, Dec 16, 2018
  12. 1/3 git-column.txt: fix section headerMartin Ågren, Dec 16, 2018
  13. 2/3 Documentation: do not nest open blocksMartin Ågren, Dec 16, 2018
  14. 3/3 git-status.txt: render tables correctly under AsciidoctorMartin Ågren, Dec 16, 2018
  15. Jeff KingDec 16, 2018
  16. Jeff KingDec 16, 2018
  17. Martin ÅgrenDec 16, 2018
  18. Jeff KingDec 16, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.