git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/4] git-status.txt: render tables correctly under Asciidoctor

From
Jeff King <peff@peff.net>
Date
Dec 16, 2018, 10:59 UTC
Message-ID
<20181216105944.GG13704@sigill.intra.peff.net>
In-Reply-To
<20181215112742.1475882-5-martin.agren@gmail.com>
On Sat, Dec 15, 2018 at 12:27:42PM +0100, Martin Ågren wrote:
Show 12 quoted lines
> Asciidoctor removes the indentation of each line in these tables, so the
> last lines of each table have a completely broken alignment.
> 
> Similar to 379805051d ("Documentation: render revisions correctly under
> Asciidoctor", 2018-05-06), use an explicit literal block to indicate
> that we want to keep the leading whitespace in the tables.
> 
> Because this gives us some extra indentation, we can remove the one that
> we have been carrying explicitly. That is, drop the first four spaces of
> indentation on each line. With Asciidoc (8.6.10), this results in
> identical rendering before and after this commit, both for git-status.1
> and git-status.html.
Yep, this makes sense based on the prior art you cited.
The whole series looks good to me. Thanks for working on it!
-Peff
Previous: Martin ÅgrenNext: Martin Ågren
Message 10 of 18 in “A few Asciidoctor-fixes”
  1. 0/4 A few Asciidoctor-fixesMartin Ågren, Dec 15, 2018
  2. 1/4 git-column.txt: fix section headerMartin Ågren, Dec 15, 2018
  3. Jeff KingDec 16, 2018
  4. Martin ÅgrenDec 16, 2018
  5. 2/4 git-init.txt: do not nest open blocksMartin Ågren, Dec 15, 2018
  6. Jeff KingDec 16, 2018
  7. 3/4 rev-list-options.txt: do not nest open blocksMartin Ågren, Dec 15, 2018
  8. Jeff KingDec 16, 2018
  9. 4/4 git-status.txt: render tables correctly under AsciidoctorMartin Ågren, Dec 15, 2018
  10. Jeff KingDec 16, 2018
  11. 0/3 A few Asciidoctor-fixesMartin Ågren, Dec 16, 2018
  12. 1/3 git-column.txt: fix section headerMartin Ågren, Dec 16, 2018
  13. 2/3 Documentation: do not nest open blocksMartin Ågren, Dec 16, 2018
  14. 3/3 git-status.txt: render tables correctly under AsciidoctorMartin Ågren, Dec 16, 2018
  15. Jeff KingDec 16, 2018
  16. Jeff KingDec 16, 2018
  17. Martin ÅgrenDec 16, 2018
  18. Jeff KingDec 16, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.