Re: [PATCH 0/4] A few Asciidoctor-fixes

From: Jeff King <peff@peff.net>
Date: Dec 16, 2018, 16:17 UTC
Message-ID: <20181216161720.GA1511@sigill.intra.peff.net>
In-Reply-To: <CAN0heSrccWop+KRKFCTNHTB43XcAv+Q8X7p0hT1t2+rPjS1THA@mail.gmail.com>

On Sun, Dec 16, 2018 at 03:34:42PM +0100, Martin Ågren wrote:

Show 16 quoted lines

> Your list seems complete to me in terms of "how could we teach doc-diff
> to diff asciidoctor vs asciidoc?". For the resulting diff to actually be
> useful ;-) there are two more outstanding issues that I see:
> 
>   - Headers and footers. Asciidoc (driven by doc-diff) uses some
>     boilerplate values which avoid timestamps and the like. Asciidoctor
>     partly uses different values, partly interprets the ones given
>     differently.
> 
>   - Asciidoctor introduces a space after linkgit:foo , e.g., before
>     punctuation.
> 
> Both of these are problems in their own right, so they probably
> shouldn't be suppressed in the resulting diff. But as long as these
> issues remain, they produce a lot of noise which might hide more
> interesting (IMHO) differences.

If there are a small number of distinct problems (that each have many instances), I'm not opposed to having a mode to suppress them in the resulting diff, so we can see the other problems more clearly. Of course, just fixing them is even better. ;)

The first one sounds like it may be a candidate for suppressing (i.e., it's not necessarily an actual problem).

-Peff