git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] git-init.txt: do not nest open blocks

From
Jeff King <peff@peff.net>
Date
Dec 16, 2018, 10:55 UTC
Message-ID
<20181216105505.GE13704@sigill.intra.peff.net>
In-Reply-To
<20181215112742.1475882-3-martin.agren@gmail.com>
On Sat, Dec 15, 2018 at 12:27:40PM +0100, Martin Ågren wrote:
Show 5 quoted lines
> It appears we try to nest open blocks, but that does not work well with
> Asciidoctor, which fails to indent the inner block. This causes the
> inner block to be set as if it had nothing to do with `--shared`. Drop
> the outer one. Asciidoc renders identically before and after this patch,
> both man-page and html.

Hrm. I'm not sure how we're supposed to have a block-within-a-block in asciidoctor, and that may be something we want to fix in the long run. But I agree this block around all of the options is not doing anything useful, and the simplest solution here is just to get rid of it.

It dates all the way back to d145144c3b (Document git-init, 2007-01-11), so perhaps it did something useful in an ancient version of asciidoc.

-Peff
Previous: Martin ÅgrenNext: Martin Ågren
Message 6 of 18 in “A few Asciidoctor-fixes”
  1. 0/4 A few Asciidoctor-fixesMartin Ågren, Dec 15, 2018
  2. 1/4 git-column.txt: fix section headerMartin Ågren, Dec 15, 2018
  3. Jeff KingDec 16, 2018
  4. Martin ÅgrenDec 16, 2018
  5. 2/4 git-init.txt: do not nest open blocksMartin Ågren, Dec 15, 2018
  6. Jeff KingDec 16, 2018
  7. 3/4 rev-list-options.txt: do not nest open blocksMartin Ågren, Dec 15, 2018
  8. Jeff KingDec 16, 2018
  9. 4/4 git-status.txt: render tables correctly under AsciidoctorMartin Ågren, Dec 15, 2018
  10. Jeff KingDec 16, 2018
  11. 0/3 A few Asciidoctor-fixesMartin Ågren, Dec 16, 2018
  12. 1/3 git-column.txt: fix section headerMartin Ågren, Dec 16, 2018
  13. 2/3 Documentation: do not nest open blocksMartin Ågren, Dec 16, 2018
  14. 3/3 git-status.txt: render tables correctly under AsciidoctorMartin Ågren, Dec 16, 2018
  15. Jeff KingDec 16, 2018
  16. Jeff KingDec 16, 2018
  17. Martin ÅgrenDec 16, 2018
  18. Jeff KingDec 16, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.