Re: [PATCH 0/3] refspec: refactor & fix free() behavior

From: Martin Ågren <martin.agren@gmail.com>
Date: Jun 5, 2018, 20:20 UTC
Message-ID: <CAN0heSqsxzTmGSaLLOn0FiWhjt9kBuRAtfxua7iVGoXeLxobww@mail.gmail.com>
In-Reply-To: <20180605195816.GC158365@google.com>

On 5 June 2018 at 21:58, Brandon Williams <bmwill@google.com> wrote:

Show 12 quoted lines

> On 06/05, Ævar Arnfjörð Bjarmason wrote:
>> Since Martin & Brandon both liked this direction I've fixed it
>> up.
>>
>> Martin: I didn't want to be the author of the actual fix for the bug
>> you found, so I rewrote your commit in 3/3. The diff is different, and
>> I slightly modified the 3rd paragraph of the commit message & added my
>> sign-off, but otherwise it's the same.
>
> Thanks for writing up a proper patch series for this fix.  I liked
> breaking up your diff into two different patches to make it clear that
> all callers of refpsec_item_init relying on dieing.

Me too.

>> Martin Ågren (1):
>>   refspec: initalize `refspec_item` in `valid_fetch_refspec()`

I was a bit surprised at first that this wasn't a "while at it" in the second patch, but on second thought, it does make sense to keep this separate. Thanks for picking this up and polishing it.

Just noticed: s/initalize/initialize/. That would be my fault...

Martin