Re: [PATCH 0/3] refspec: refactor & fix free() behavior

From: Brandon Williams <bmwill@google.com>
Date: Jun 5, 2018, 19:58 UTC
Message-ID: <20180605195816.GC158365@google.com>
In-Reply-To: <20180605195440.8505-1-avarab@gmail.com>

On 06/05, Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

> Since Martin & Brandon both liked this direction I've fixed it
> up.
> 
> Martin: I didn't want to be the author of the actual fix for the bug
> you found, so I rewrote your commit in 3/3. The diff is different, and
> I slightly modified the 3rd paragraph of the commit message & added my
> sign-off, but otherwise it's the same.

Thanks for writing up a proper patch series for this fix. I liked breaking up your diff into two different patches to make it clear that all callers of refpsec_item_init relying on dieing.

Show 17 quoted lines

> 
> Martin Ågren (1):
>   refspec: initalize `refspec_item` in `valid_fetch_refspec()`
> 
> Ævar Arnfjörð Bjarmason (2):
>   refspec: s/refspec_item_init/&_or_die/g
>   refspec: add back a refspec_item_init() function
> 
>  builtin/clone.c |  2 +-
>  builtin/pull.c  |  2 +-
>  refspec.c       | 13 +++++++++----
>  refspec.h       |  5 ++++-
>  4 files changed, 15 insertions(+), 7 deletions(-)
> 
> -- 
> 2.17.0.290.gded63e768a
>

-- 
Brandon Williams