git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] fix spurious space after linkgit, now in *.html

From
MÅMartin Ågren <martin.agren@gmail.com>
Date
Mar 11, 2019, 05:47 UTC
Message-ID
<CAN0heSqpZRaEjZpRAizy6wudf+fAAOwJWYdtf7OJP3SRoXf1Sw@mail.gmail.com>
In-Reply-To
<20190311025952.GA6425@sigill.intra.peff.net>
On Mon, 11 Mar 2019 at 03:59, Jeff King <peff@peff.net> wrote:
Show 21 quoted lines
>
> On Sun, Mar 10, 2019 at 04:14:22PM +0100, Martin Ågren wrote:
>
> > [1] I could have sworn I checked the html docs and saw that they didn't
> > have this extra space. Looking at git-scm.com again reveals that it's
> > not there. Huh. Seems like the site's html-rendering doesn't go through our
> > Makefile at all and handles "linkgit:" on its own:
> > https://github.com/git/git-scm.com/blob/master/script/doc_importer
>
> Correct. It significantly predates any support for asciidoctor in our
> Makefile, and needs to do some custom ruby-level tweaking (though
> possibly that could be cleaned up these days).
>
> The doc_importer script you found, though, is not part of that process.
> I _think_ it's just leftover cruft. The actual import and conversion
> happens as part of the rake task in:
>
>   https://github.com/git/git-scm.com/blob/master/lib/tasks/index.rake
>
> (Not that any of this matters for your series; just sprinkling some fun
> facts into the conversation).
Thanks for this background info, and for the correct link. :-)
Martin
Previous: Jeff KingNext: Junio C Hamano
Message 24 of 31 in “asciidoctor-extensions: fix spurious space after linkgit”
  1. 0/3 asciidoctor-extensions: fix spurious space after linkgitMartin Ågren, Feb 25, 2019
  2. 1/3 Documentation/Makefile: add missing xsl dependencies for manpagesMartin Ågren, Feb 25, 2019
  3. Eric SunshineFeb 25, 2019
  4. Martin ÅgrenFeb 25, 2019
  5. Eric SunshineFeb 25, 2019
  6. Martin ÅgrenFeb 26, 2019
  7. Eric SunshineFeb 26, 2019
  8. Martin ÅgrenFeb 27, 2019
  9. 2/3 Documentation/Makefile: add missing dependency on asciidoctor-extensionsMartin Ågren, Feb 25, 2019
  10. 3/3 asciidoctor-extensions: fix spurious space after linkgitMartin Ågren, Feb 25, 2019
  11. brian m. carlsonFeb 26, 2019
  12. brian m. carlsonFeb 26, 2019
  13. Martin ÅgrenFeb 26, 2019
  14. 0/3 asciidoctor-extensions: fix spurious space after linkgitMartin Ågren, Feb 27, 2019
  15. 1/3 Documentation/Makefile: add missing xsl dependencies for manpagesMartin Ågren, Feb 27, 2019
  16. 2/3 Documentation/Makefile: add missing dependency on asciidoctor-extensionsMartin Ågren, Feb 27, 2019
  17. 3/3 asciidoctor-extensions: fix spurious space after linkgitMartin Ågren, Feb 27, 2019
  18. brian m. carlsonFeb 28, 2019
  19. Junio C HamanoMar 3, 2019
  20. 0/2 fix spurious space after linkgit, now in *.htmlMartin Ågren, Mar 10, 2019
  21. 1/2 Documentation/Makefile: add missing dependencies on asciidoctor-extensionsMartin Ågren, Mar 10, 2019
  22. 2/2 asciidoctor-extensions: fix spurious space after linkgit in *.htmlMartin Ågren, Mar 10, 2019
  23. Jeff KingMar 11, 2019
  24. Martin ÅgrenMar 11, 2019
  25. Junio C HamanoMar 11, 2019
  26. Martin ÅgrenMar 11, 2019
  27. Junio C HamanoMar 11, 2019
  28. 1/3 Documentation/Makefile: add missing xsl dependencies for manpagesJunio C Hamano, Mar 11, 2019
  29. 2/3 Documentation/Makefile: add missing dependency on asciidoctor-extensionsJunio C Hamano, Mar 11, 2019
  30. 3/3 asciidoctor-extensions: fix spurious space after linkgitJunio C Hamano, Mar 11, 2019
  31. Martin ÅgrenMar 11, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.