git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] asciidoctor-extensions: fix spurious space after linkgit

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Feb 26, 2019, 03:22 UTC
Message-ID
<20190226032201.GD601925@genre.crustytoothpaste.net>
In-Reply-To
<cover.1551123979.git.martin.agren@gmail.com>
On Mon, Feb 25, 2019 at 09:02:37PM +0100, Martin Ågren wrote:
Show 18 quoted lines
> Patch 3/3 gets rid of a spurious space which shows up immediately after
> Asciidoctor has expanded linkgit:foo[bar] if the macro is followed by
> punctuation such as a comma, period or closing parenthesis.
> 
> Patch 2/3 adds a missing dependency to the makefile, so that the docs
> will actually be rebuilt with that final patch. Patch 1/3 isn't needed
> for this series, but could help someone in the future, similar to how
> already having patch 2/3 would have helped me...
> 
> Martin Ågren (3):
>   Documentation/Makefile: add missing xsl dependencies for manpages
>   Documentation/Makefile: add missing dependency on
>     asciidoctor-extensions
>   asciidoctor-extensions: fix spurious space after linkgit
> 
>  Documentation/Makefile                  | 4 ++--
>  Documentation/asciidoctor-extensions.rb | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Thanks for putting this series together. I would suggest an update to the commit message in 1/3 explaining the edge case that Eric Sunshine mentioned, but otherwise, I think this looks good.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
Previous: brian m. carlsonNext: Martin Ågren
Message 12 of 31 in “asciidoctor-extensions: fix spurious space after linkgit”
  1. 0/3 asciidoctor-extensions: fix spurious space after linkgitMartin Ågren, Feb 25, 2019
  2. 1/3 Documentation/Makefile: add missing xsl dependencies for manpagesMartin Ågren, Feb 25, 2019
  3. Eric SunshineFeb 25, 2019
  4. Martin ÅgrenFeb 25, 2019
  5. Eric SunshineFeb 25, 2019
  6. Martin ÅgrenFeb 26, 2019
  7. Eric SunshineFeb 26, 2019
  8. Martin ÅgrenFeb 27, 2019
  9. 2/3 Documentation/Makefile: add missing dependency on asciidoctor-extensionsMartin Ågren, Feb 25, 2019
  10. 3/3 asciidoctor-extensions: fix spurious space after linkgitMartin Ågren, Feb 25, 2019
  11. brian m. carlsonFeb 26, 2019
  12. brian m. carlsonFeb 26, 2019
  13. Martin ÅgrenFeb 26, 2019
  14. 0/3 asciidoctor-extensions: fix spurious space after linkgitMartin Ågren, Feb 27, 2019
  15. 1/3 Documentation/Makefile: add missing xsl dependencies for manpagesMartin Ågren, Feb 27, 2019
  16. 2/3 Documentation/Makefile: add missing dependency on asciidoctor-extensionsMartin Ågren, Feb 27, 2019
  17. 3/3 asciidoctor-extensions: fix spurious space after linkgitMartin Ågren, Feb 27, 2019
  18. brian m. carlsonFeb 28, 2019
  19. Junio C HamanoMar 3, 2019
  20. 0/2 fix spurious space after linkgit, now in *.htmlMartin Ågren, Mar 10, 2019
  21. 1/2 Documentation/Makefile: add missing dependencies on asciidoctor-extensionsMartin Ågren, Mar 10, 2019
  22. 2/2 asciidoctor-extensions: fix spurious space after linkgit in *.htmlMartin Ågren, Mar 10, 2019
  23. Jeff KingMar 11, 2019
  24. Martin ÅgrenMar 11, 2019
  25. Junio C HamanoMar 11, 2019
  26. Martin ÅgrenMar 11, 2019
  27. Junio C HamanoMar 11, 2019
  28. 1/3 Documentation/Makefile: add missing xsl dependencies for manpagesJunio C Hamano, Mar 11, 2019
  29. 2/3 Documentation/Makefile: add missing dependency on asciidoctor-extensionsJunio C Hamano, Mar 11, 2019
  30. 3/3 asciidoctor-extensions: fix spurious space after linkgitJunio C Hamano, Mar 11, 2019
  31. Martin ÅgrenMar 11, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.