Re: [PATCH 0/2] fix spurious space after linkgit, now in *.html

From: Jeff King <peff@peff.net>
Date: Mar 11, 2019, 02:59 UTC
Message-ID: <20190311025952.GA6425@sigill.intra.peff.net>
In-Reply-To: <cover.1552230490.git.martin.agren@gmail.com>

On Sun, Mar 10, 2019 at 04:14:22PM +0100, Martin Ågren wrote:

Show 5 quoted lines

> [1] I could have sworn I checked the html docs and saw that they didn't
> have this extra space. Looking at git-scm.com again reveals that it's
> not there. Huh. Seems like the site's html-rendering doesn't go through our
> Makefile at all and handles "linkgit:" on its own:
> https://github.com/git/git-scm.com/blob/master/script/doc_importer

Correct. It significantly predates any support for asciidoctor in our Makefile, and needs to do some custom ruby-level tweaking (though possibly that could be cleaned up these days).

The doc_importer script you found, though, is not part of that process. I _think_ it's just leftover cruft. The actual import and conversion happens as part of the rake task in:

  https://github.com/git/git-scm.com/blob/master/lib/tasks/index.rake

(Not that any of this matters for your series; just sprinkling some fun facts into the conversation).

-Peff