Re: [PATCH 1/3] Documentation/Makefile: add missing xsl dependencies for manpages

From: Martin Ågren <martin.agren@gmail.com>
Date: Feb 26, 2019, 05:59 UTC
Message-ID: <CAN0heSoWv9xTYzFS16-fjnZuY_+6vpHSHcLmwWG8DdJEmNcTuA@mail.gmail.com>
In-Reply-To: <CAPig+cRTj_jHFrqyYsn=ivuO9uNcWjB=5okX0SCGoeWU=uR8Gw@mail.gmail.com>

On Mon, 25 Feb 2019 at 22:01, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 11 quoted lines

>
> On Mon, Feb 25, 2019 at 3:29 PM Martin Ågren <martin.agren@gmail.com> wrote:
> > On Mon, 25 Feb 2019 at 21:08, Eric Sunshine <sunshine@sunshineco.com> wrote:
> > >
> > > The wildcard expression also matches the manpage-base-url.xsl
> > > mentioned explicitly. Did you intentionally retain the explicit one or
> > > was that an oversight?
> >
> > Hmm, I should have mentioned that, thanks for asking for clarification.
> >
> > It's intentional.

> I guess I was further confused by the fact that manpage-base-url.xsl
> is still present even after "make distclean", which is not something I
> would have expected for a generated file. (Perhaps something to
> consider "fixing" if you re-roll, or not if it's out of scope.)

Are you sure? `make distclean` in the top directory depends on the "clean" target, which calls out to `make -C Documentation/ clean`, which removes the file. A test-run works here:

Before:

$ ls | grep manpage-base manpage-base-url.xsl manpage-base-url.xsl.in manpage-base.xsl

After:

$ ls | grep manpage-base manpage-base-url.xsl.in manpage-base.xsl

Were you perhaps mislead by one of the similarly-named files?

Martin