Re: [PATCH v2] macos: lazily initialize iconv
- From
Ralf Thielow <ralf.thielow@gmail.com>
- Date
- Jul 31, 2012, 18:55 UTC
- Message-ID
- <CAN0XMOKBPirJFzHM_QgDC8TGimoEhjWoAVA+JhaLzto4-SVvmw@mail.gmail.com>
- In-Reply-To
- <7v1ujrkc9p.fsf@alter.siamese.dyndns.org>
On Tue, Jul 31, 2012 at 8:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 7 quoted lines
> + /* Avoid iconv_open()/iconv_close() if there is nothing to convert */
> + for (i = 0; i < argc; i++) {
> + if (has_utf8(argv[i], (size_t)-1, NULL))
> + break;
> + }
> + if (argc <= i)
> + return; /* no utf8 found */sorry, but "argc" can never be smaller than "i", right?