Re: [PATCH v2] macos: lazily initialize iconv

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 10, 2012, 21:47 UTC
Message-ID: <7v7gt6ifmd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <50257906.1010606@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

Show 17 quoted lines

> After cloning, I set "git config core.precomposeunicode true".
>
> git is v1.7.12.rc2,
> git_git/git is with your patch.
> 
> git v1.7.12.rc2:
> tb@birne:~/projects/git/linux-2.6> for f in 1 2 3 4 5; do time git status  ; done 2>&1 | egrep "^user|^real|^sys"
> real    0m0.460s
> user    0m0.283s
> sys     0m0.176s
>
> With lazy init of iconv:
> tb@birne:~/projects/git/linux-2.6> for f in 1 2 3 4 5; do time ~/projects/git/git_git/git status  ; done 2>&1 | egrep "^user|^real|^sys"
>
> real    0m0.462s
> user    0m0.281s
> sys     0m0.177s

Thanks.

So in short, even in a tree that theoretically should benefit from lazy initialization, it does not make things better in any measuable way.