Re: [PATCH] macos: lazily initialize iconv

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 31, 2012, 18:19 UTC
Message-ID: <7v6293kd2y.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAN0XMOL6m0B0bLwdp9mviOLqYORGcnf9LMS5=+WkXhGinBrzgA@mail.gmail.com>

Ralf Thielow <ralf.thielow@gmail.com> writes:

Show 16 quoted lines

> On Tue, Jul 31, 2012 at 7:52 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> +       /* Avoid iconv_open()/iconv_close() if there is nothing to convert */
>> +       for (i = 0; i < argc; i++) {
>> +               if (has_utf8(argv[i], (size_t)-1, NULL))
>> +                       break;
>> +       }
>> +       if (i < argc)
>> +               return;
>> +
>
> I'm not very familiar with this code but:
>
> before: it reencodes everything which is utf-8 in argv
> after: it reencodes *nothing* if one string in argv is not in utf-8
>
> am i wrong?

You are right. It should avoid the whole iconv thing if we saw _no_ utf8, i.e. the last two should be:

	if (argc <= i)
        	return;

Thanks.