Re: [PATCH v2] macos: lazily initialize iconv

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 10, 2012, 18:18 UTC
Message-ID: <7vsjbuk3v3.fsf@alter.siamese.dyndns.org>
In-Reply-To: <50253A1E.20706@web.de>

Torsten Bögershausen <tboegi@web.de> writes:

Show 18 quoted lines

> On 31.07.12 20:37, Junio C Hamano wrote:
>> In practice, the majority of paths do not have utf8 that needs
>> the canonicalization. Lazily call iconv_open()/iconv_close() to
>> avoid unnecessary overhead.
>>
>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>> Helped-by: Ralf Thielow <ralf.thielow@gmail.com>
>> Helped-by: Linus Torvalds <torvalds@linux-foundation.org>
>> ---
>>
>>  * This is not even compile tested, so it needs testing and
>>    benchmarking, as I do not even know how costly the calls to
>>    open/close are when we do not have to call iconv() itself.
>> ...
> Hi Junio,
>
> thanks for the optimization.
> Tested-by: Torsten Bögershausen <tboegi@web.de>

Well, I didn't mean the correctness testing without numbers. The correctness of the patch after a couple of people eyeballed it was no longer a question.

If the patch does not give any measuable performance difference to people who exercise this codepath, it is not worth merging. And that is not something I can't do myself without a Mac (nor I wish to have one to be able to do so myself).

Thanks.