git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] completion: ignore chpwd_functions when cding

From
Brandon Turner <bt@brandonturner.net>
Date
Oct 8, 2014, 21:50 UTC
Message-ID
<CAMUzdXkQcbwhmJRYog+X_9B_cdWv6FkTrVFT__Dsw2k+qKN0=g@mail.gmail.com>
In-Reply-To
<xmqqh9zebfc6.fsf@gitster.dls.corp.google.com>
On Wed, Oct 8, 2014 at 1:12 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
>
>
> Can you mention that this is abomination limited only to zsh
> somewhere in the log message?  Or does bash share the same glitch?
>
> If this is limited to zsh, I wonder if we can take advantage of the
> fact that we have git-completion.bash and git-completion.zsh to
> avoid contaminating shared part of the code.

I'm going to submit two versions of the patch: v2 - addresses the log message, but the patch still applies to bash and zsh v3 - moves the change to git-completion.zsh as an override, bash is unaffected

>From my testing, bash is unaffected, so v3 would be an ok fix.  Since

we cannot control what functions users add to chpwd_functions, v2 might make more sense.

Previous: Øystein Walle
Message 16 of 16 in “completion: ignore chpwd_functions when cding”
  1. completion: ignore chpwd_functions when cdingBrandon Turner, Oct 8, 2014
  2. Junio C HamanoOct 8, 2014
  3. completion: ignore chpwd_functions when cdingBrandon Turner, Oct 8, 2014
  4. completion: ignore chpwd_functions when cding on zshBrandon Turner, Oct 8, 2014
  5. Øystein WalleOct 9, 2014
  6. Junio C HamanoOct 9, 2014
  7. completion: ignore chpwd_functions when cding on zshBrandon Turner, Oct 9, 2014
  8. Øystein WalleOct 9, 2014
  9. Junio C HamanoOct 9, 2014
  10. Junio C HamanoOct 9, 2014
  11. Brandon TurnerOct 9, 2014
  12. Junio C HamanoOct 9, 2014
  13. Brandon TurnerOct 9, 2014
  14. Øystein WalleOct 16, 2014
  15. Øystein WalleOct 9, 2014
  16. Brandon TurnerOct 8, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.