git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4] completion: ignore chpwd_functions when cding on zsh

From
Øystein Walle <oystwa@gmail.com>
Date
Oct 16, 2014, 18:10 UTC
Message-ID
<loom.20141016T200635-928@post.gmane.org>
In-Reply-To
<CAMUzdXkWNxW8Py6ATwtvqJ7s75dsP8vz6gMjk6tQa6gTGvcdWw@mail.gmail.com>
Brandon Turner <bt <at> brandonturner.net> writes:
Show 11 quoted lines
> 
> On Thu, Oct 9, 2014 at 5:11 PM, Junio C Hamano <gitster <at> pobox.com> wrote:
> > Actually the patch was slightly wrong.  It did not quite matter as
> > "cd ''" is a no-op, but "git -C '' cmd" is not that lenient (which
> > may be something we may want to fix) and breaks t9902 by exposing
> > an existing breakage in the callchain.
> >
> > Here is a replacement.
> 
> I did some more testing on this iteration as well - looks good. 
> 
Sorry, for the late reply, guys...
I've tested it too and it seems to work just fine.

As for my comments about using $=2 instead of $2: When zsh runs through this code it does so while emulating ksh. Thus the reliance on splitting unquoted expansions is not a problem. I was unaware of this until ten minutes ago. 

Øsse
Previous: Brandon TurnerNext: Øystein Walle
Message 14 of 16 in “completion: ignore chpwd_functions when cding”
  1. completion: ignore chpwd_functions when cdingBrandon Turner, Oct 8, 2014
  2. Junio C HamanoOct 8, 2014
  3. completion: ignore chpwd_functions when cdingBrandon Turner, Oct 8, 2014
  4. completion: ignore chpwd_functions when cding on zshBrandon Turner, Oct 8, 2014
  5. Øystein WalleOct 9, 2014
  6. Junio C HamanoOct 9, 2014
  7. completion: ignore chpwd_functions when cding on zshBrandon Turner, Oct 9, 2014
  8. Øystein WalleOct 9, 2014
  9. Junio C HamanoOct 9, 2014
  10. Junio C HamanoOct 9, 2014
  11. Brandon TurnerOct 9, 2014
  12. Junio C HamanoOct 9, 2014
  13. Brandon TurnerOct 9, 2014
  14. Øystein WalleOct 16, 2014
  15. Øystein WalleOct 9, 2014
  16. Brandon TurnerOct 8, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.