git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] completion: ignore chpwd_functions when cding

From
Brandon Turner <bt@brandonturner.net>
Date
Oct 8, 2014, 03:53 UTC
Message-ID
<1412740394-34061-1-git-send-email-bt@brandonturner.net>

Software, such as RVM (ruby version manager), may set chpwd functions that result in an endless loop when cding. chpwd functions should be ignored.

Signed-off-by: Brandon Turner <bt@brandonturner.net>
---
For an example of this bug, see:
https://github.com/wayneeseguin/rvm/issues/3076
 contrib/completion/git-completion.bash | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 06bf262..996de31 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -283,7 +283,8 @@ __git_ls_files_helper ()
 {
 	(
 		test -n "${CDPATH+set}" && unset CDPATH
-		cd "$1"
+		(( ${#chpwd_functions} )) && chpwd_functions=()
+		builtin cd "$1"
 		if [ "$2" == "--committable" ]; then
 			git diff-index --name-only --relative HEAD
 		else
-- 
2.1.2
Next: Junio C Hamano
Message 1 of 16 in “completion: ignore chpwd_functions when cding”
  1. completion: ignore chpwd_functions when cdingBrandon Turner, Oct 8, 2014
  2. Junio C HamanoOct 8, 2014
  3. completion: ignore chpwd_functions when cdingBrandon Turner, Oct 8, 2014
  4. completion: ignore chpwd_functions when cding on zshBrandon Turner, Oct 8, 2014
  5. Øystein WalleOct 9, 2014
  6. Junio C HamanoOct 9, 2014
  7. completion: ignore chpwd_functions when cding on zshBrandon Turner, Oct 9, 2014
  8. Øystein WalleOct 9, 2014
  9. Junio C HamanoOct 9, 2014
  10. Junio C HamanoOct 9, 2014
  11. Brandon TurnerOct 9, 2014
  12. Junio C HamanoOct 9, 2014
  13. Brandon TurnerOct 9, 2014
  14. Øystein WalleOct 16, 2014
  15. Øystein WalleOct 9, 2014
  16. Brandon TurnerOct 8, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.